Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq Enterprise: until matcher #147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sidekiq Enterprise: until matcher #147

wants to merge 3 commits into from
+72 −1

Conversation

leviwilson
Copy link

Description

In Sidekiq Enterprise's Unique Jobs feature, you have the ability to specify an unlock policy.

This PR adds an until matcher so that you may specify an expectation against a worker for it like so:

describe MuhWorker do
  it { should be_unique.until(:success) }
end

It also will fail that it is not supported if a user tries to use it with SidekiqUniqueJobs.

@leviwilson
introduce until matcher to match unique_until
e65e512 
Sidekiq Enterprise use a unique_until option to
specify when the uniqueness is allowed to go
away.

This matcher allows you to write specifications
against a worker to validate those expectations.
@leviwilson
add specification for until for the message when one is not provided
34d8bad
@leviwilson
add failure scenario for when SidekiqUniqueJobs tries to use it
7ff2c85
@coveralls
Copy link

Coverage Status

Coverage increased (+4.03%) to 98.652% when pulling 7ff2c85 on northwoodspd:sidekiq_pro_until_matcher into 807cb13 on philostler:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 21, 2017 •
edited
Loading

Coverage Status

Coverage increased (+4.03%) to 98.652% when pulling 7ff2c85 on northwoodspd:sidekiq_pro_until_matcher into 807cb13 on philostler:develop.

@wspurgin wspurgin added the stale label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leviwilson @coveralls @wspurgin